https://bugs.kde.org/show_bug.cgi?id=356045
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kio
| |/074c91a58318f201d8c47076a5
| |a9cf4ff783a051
Version Fixed In| |5.60
--- Comment #6 from Nate Graham <n...@kde.org> ---
Git commit 074c91a58318f201d8c47076a5a9cf4ff783a051 by Nate Graham.
Committed on 30/06/2019 at 15:21.
Pushed by ngraham into branch 'master'.
Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()
Summary:
`KIO::iconNameForUrl()` was doing a lot of redundant work on file items that
`KFileItem::iconName()`
already does for us. This patch moves most of that logic into
`KIO::iconNameForUrl()` when operating
on local files (but not for remote files, which may be slower, and for which we
don't want to stat).
FIXED-IN: 5.60
Test Plan:
Functionality testing:
- Tested that adding a directory with a custom icon to the Places panel resuts
in the Places panel entry inheriting its custom icon: {F5864410}
- Used the system with this patch in place for one year; did not find any
instances of incorrect icons
Regression testing:
- Tested that the trash changes its icon appropriately when adding an item to
an empty trash, removing all items from the trash, and emptying the trash
(testtrash test passes)
- Tested that other icons on the Places panel look the same as they did before
the patch
Unit testing:
- No test regressions
Reviewers: #frameworks, broulik, meven, apol, dfaure
Reviewed By: dfaure
Subscribers: apol, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D13048
M +21 -11 src/core/global.cpp
https://commits.kde.org/kio/074c91a58318f201d8c47076a5a9cf4ff783a051
--
You are receiving this mail because:
You are watching all bug changes.
