https://bugs.kde.org/show_bug.cgi?id=79903

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.59
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |/f0668888660ffcbe578884c5e8
                   |                            |0cef53b16be50d

--- Comment #8 from Nate Graham <n...@kde.org> ---
Git commit f0668888660ffcbe578884c5e80cef53b16be50d by Nate Graham.
Committed on 06/05/2019 at 16:15.
Pushed by ngraham into branch 'master'.

[FileWidget] Replace "Filter:" with "File type:" when saving with a limited
list of mimetypes

Summary:
The Filter combobox currently always has the label "Filter:" This is
appropriate in most
cases, but becomes inaccurate when saving with a limited list of mimetypes. In
this case,
the combobox loses its text field and becomes a file type chooser rather than a
filter.

This patch changes the label to "File type:" for that use case.
FIXED-IN: 5.59

Test Plan:
Opening a file: no changes
{F6803789}

Saving a file with no mimetype filter: no changes
{F6803788}

Saving a file with a limited list of mimetypes: label is changed
{F6803790}

Reviewers: #vdg, elvisangelaccio, GB_2

Reviewed By: elvisangelaccio

Subscribers: pino, apol, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T8552

Differential Revision: https://phabricator.kde.org/D20964

M  +34   -9    src/filewidgets/kfilewidget.cpp

https://commits.kde.org/kio/f0668888660ffcbe578884c5e80cef53b16be50d

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to