https://bugs.kde.org/show_bug.cgi?id=361691
--- Comment #12 from Stephen Kelly <steve...@gmail.com> --- Your benchmark is only for the case of the searched string being empty. In other benchmarks here, the two perform the same. That isn't a good reason for clazy to recommend something that 1) goes against the general recommendation, 2) we don't have strong benchmarks in favor of. After https://codereview.qt-project.org/156181 I get results for your benchmark which are the same within experimental error. Please apply it and confirm. If you think clazy should continue to recommend non-use of QLatin1String for these methods, please provide a better benchmark than either of the ones we've posted so far. -- You are receiving this mail because: You are watching all bug changes.
