https://bugs.kde.org/show_bug.cgi?id=405585

Christoph Cullmann <cullm...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/syn
                   |                            |tax-highlighting/a241449526
                   |                            |88f6e6b8700d5c86c563264715f
                   |                            |8a7
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #6 from Christoph Cullmann <cullm...@kde.org> ---
Git commit a24144952688f6e6b8700d5c86c563264715f8a7 by Christoph Cullmann, on
behalf of Nibaldo González.
Committed on 24/03/2019 at 13:07.
Pushed by cullmann into branch 'master'.

Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

Summary:

There is a problem of folding in rules with beginRegion + endRegion.

Example:
```
<StringDetect String="hello" endRegion="region1" beginRegion="region2" />
```
In this case, the "hello" string is part of the "region1" and "region2" regions
simultaneously, which generates folding problems. The ideal behavior is that
"hello" isn't part of "region1", but of "region2". That is, don't publish
length of endRegion folding in rules with beginRegion+endRegion.

For example, in `.desktop` files:
{F6715422}

The following XML files use rules with beginRegion + endRegion:
* ansforth94.xml
* apparmor.xml
* asciidoc.xml
* asp.xml c.xml
* cisco.xml
* desktop.xml
* fortran.xml
* haml.xml
* ini.xml
* isocpp.xml
* julia.xml
* lex.xml
* lua.xml
* makefile.xml
* perl.xml
* pony.xml
* rhtml.xml
* rpmspec.xml
* ruby.xml
* template-toolkit.xml
* txt2tags.xml
* yacc.xml

Reviewers: #framework_syntax_highlighting, cullmann, dhaumann, vkrause

Reviewed By: #framework_syntax_highlighting, cullmann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D19999

M  +2    -2    autotests/folding/Makefile.fold
M  +2    -2    autotests/folding/folding.cpp.fold
M  +1    -1    autotests/folding/highlight.asp.fold
M  +20   -20   autotests/folding/highlight.cpp.fold
M  +1    -1    autotests/folding/highlight.f90.fold
M  +2    -2    autotests/folding/highlight.lex.fold
M  +3    -3    autotests/folding/highlight.pl.fold
M  +1    -1    autotests/folding/highlight.pony.fold
M  +1    -1    autotests/folding/highlight.prg.fold
M  +19   -19   autotests/folding/highlight.rb.fold
M  +3    -3    autotests/folding/highlight.spec.fold
M  +7    -7    autotests/folding/highlight.t2t.fold
M  +2    -2    autotests/folding/highlight.y.fold
M  +15   -1    autotests/folding/test.desktop.fold
M  +3    -3    autotests/folding/test.ini.fold
M  +6    -6    autotests/folding/usr.bin.apparmor-profile-test.fold
M  +14   -0    autotests/html/test.desktop.html
M  +14   -0    autotests/input/test.desktop
M  +14   -0    autotests/reference/test.desktop.ref
M  +9    -2    src/lib/abstracthighlighter.cpp

https://commits.kde.org/syntax-highlighting/a24144952688f6e6b8700d5c86c563264715f8a7

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to