https://bugs.kde.org/show_bug.cgi?id=395590
Elvis Angelaccio <elvis.angelac...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Version Fixed In| |1.2.4
Status|UNCONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kio
| |-gdrive/98eac3003a07a7b785c
| |916950076d7b0d56d6d61
--- Comment #1 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit 98eac3003a07a7b785c916950076d7b0d56d6d61 by Elvis Angelaccio.
Committed on 29/06/2018 at 08:44.
Pushed by elvisangelaccio into branch '1.2'.
Use percent encoding when creating urls for UDS entries
Summary:
Otherwise it won't be possible to open gdrive files that contain special
characters (such as `#`) in their path.
This is not handled by libkgapi, which just copies whatever is in the
JSON from Google, and Google does not seem to encode the filenames
either. So we encode the filenames at the kio-gdrive level, where we
actually play with QUrls.
We do so by actually creating a QUrl (which takes care of
percent-encoding in `setPath()`) and then we convert it to a string.
While at it, use faster concatenation rather than arg parsing.
FIXED-IN: 1.2.4
Test Plan:
Try to open a file with `#` in the name.
Check whether files with normal names still work.
Reviewers: dvratil, dfaure
Differential Revision: https://phabricator.kde.org/D13691
M +23 -6 autotests/urltest.cpp
M +15 -1 src/kio_gdrive.cpp
M +1 -0 src/kio_gdrive.h
https://commits.kde.org/kio-gdrive/98eac3003a07a7b785c916950076d7b0d56d6d61
--
You are receiving this mail because:
You are watching all bug changes.
