https://bugs.kde.org/show_bug.cgi?id=386533
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kam
| |era/5bc0682c3a1e80d1a356918
| |96816f2475eb3905f
Resolution|DUPLICATE |FIXED
--- Comment #2 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 5bc0682c3a1e80d1a35691896816f2475eb3905f by David Edmundson.
Committed on 22/03/2018 at 01:00.
Pushed by davidedmundson into branch 'master'.
Fix dangly pointer if gp_context_new fails
Summary:
m_deviceModel is typically created in the constructor, except in the
code path where m_context fails.
At this point we have a dangly pointer that the rest of the code uses
uncondiationally
Safer code path is to just create it earlier, we want this object in the
non-error case anyway
Test Plan:
Purely code reading
I've not got a fancy camera
Reviewers: #plasma
Differential Revision: https://phabricator.kde.org/D11564
M +2 -1 kcontrol/kamera.cpp
https://commits.kde.org/kamera/5bc0682c3a1e80d1a35691896816f2475eb3905f
--
You are receiving this mail because:
You are watching all bug changes.
