https://bugs.kde.org/show_bug.cgi?id=236970
Huon <h...@plonq.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/gwe
| |nview/576cfa68ba01b7997c4e3
| |e401b9b502ce1d6da04
--- Comment #5 from Huon <h...@plonq.org> ---
Git commit 576cfa68ba01b7997c4e3e401b9b502ce1d6da04 by Huon Imberger.
Committed on 22/03/2018 at 11:05.
Pushed by huoni into branch 'Applications/18.04'.
Add ability to constrain crop tool to current image ratio
Summary:
The crop tool was lacking the ability to choose the ratio of the current image.
This patch adds:
- Checkbox in {nav Normal} to toggle between no restriction (default),
and restrict to the current image ratio
- "Current Image" item to the Ratio combobox in {nav Advanced}
- "Unrestricted" item to the Ratio combobox in {nav Advanced}
(default, functionally no change from before)
- Clear button to the Ratio combobox in {nav Advanced}, to help make
it clear the user can enter a custom ratio
Test Plan:
# {nav Image} view > enable crop tool (e.g. by using {key shift}+{key
c}
# Ensure ratio restrictions work in both {nav Normal} and {nav Advanced}
The ratio settings in {nav Normal} and {nav Advanced} are independant of
one another, in prep for future patch which will have these remember the
chosen setting.
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: muhlenpfordt
Differential Revision: https://phabricator.kde.org/D11202
M +3 -0 lib/crop/croptool.cpp
M +68 -33 lib/crop/cropwidget.cpp
M +4 -1 lib/crop/cropwidget.h
M +8 -1 lib/crop/cropwidget.ui
M +1 -0 lib/documentview/rasterimageview.cpp
M +1 -0 lib/documentview/rasterimageview.h
https://commits.kde.org/gwenview/576cfa68ba01b7997c4e3e401b9b502ce1d6da04
--
You are receiving this mail because:
You are watching all bug changes.
