https://bugs.kde.org/show_bug.cgi?id=385942

Eike Hein <h...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |/e3a80661c9cd83677d44f4f699
                   |                            |9d24dd13629a2f
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #22 from Eike Hein <h...@kde.org> ---
Git commit e3a80661c9cd83677d44f4f6999d24dd13629a2f by Eike Hein.
Committed on 15/02/2018 at 18:46.
Pushed by hein into branch 'master'.

Stuff the "Couldn't find executable" message box into a queued lambda

Summary:
This fixes a Plasma shell crash in the Task Manager applet: We
use KRun from inside the onReleased handler of a MouseArea. In
this error case this leads to a KMessageBox spinning the event
loop. The delegate hosting the MouseArea is in the meanwhile
deleted because it's replaced by a different one for the startup
creation. After closing the dialog we're back in the destroyed
delegate and crash.

The patch instead opens the message box from a queued-up lambda
run in the context of qGuiApp (guarded by a test for qGuiApp)
so we escape the caller before starting the nested event loop.

Reviewers: dfaure, davidedmundson, mart

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D10405

M  +13   -3    src/widgets/krun.cpp

https://commits.kde.org/kio/e3a80661c9cd83677d44f4f6999d24dd13629a2f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to