https://bugs.kde.org/show_bug.cgi?id=385408

--- Comment #9 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Julian Seward from comment #8)
> This patch will need some further work before it is reviewable.
> Right now it is so huge and difficult to follow that I have no
> confidence in being able to review it properly.
I found that the patch is much easier to read when applying the whole series
and then doing "git diff --minimal origin/master".  The resulting diffstat
looks like this:
 VEX/priv/guest_s390_defs.h         |   43 +-
 VEX/priv/guest_s390_helpers.c      |   67 +-
 VEX/priv/guest_s390_toIR.c         | 2527 +++++++++++++++++++++++++++++++++++-
 VEX/priv/host_s390_defs.c          |  734 ++++++++++-
 VEX/priv/host_s390_defs.h          |   78 +-
 VEX/priv/host_s390_isel.c          |  451 ++++++-
 VEX/priv/ir_defs.c                 |  232 ++--
 VEX/priv/main_main.c               |  122 +-
 VEX/priv/s390_disasm.c             |   64 +
 VEX/priv/s390_disasm.h             |    4 +-
 VEX/pub/libvex.h                   |   40 +-
 VEX/pub/libvex_emnote.h            |   11 +-
 VEX/pub/libvex_guest_s390x.h       |  131 +-
 VEX/pub/libvex_ir.h                |  194 +--
 VEX/pub/libvex_s390x_common.h      |    3 +-
 VEX/useful/test_main.c             |   25 +
 coregrind/m_machine.c              |   21 +-
 docs/internals/s390-opcodes.csv    |  202 +--
 memcheck/mc_machine.c              |   11 +-
 memcheck/mc_translate.c            |  526 ++++----
 memcheck/tests/vbit-test/irops.c   |   13 +
 none/tests/s390x/Makefile.am       |    3 +-
 none/tests/s390x/stfle.c           |    4 +-
 none/tests/s390x/stfle.stdout.exp  |   12 +-
 none/tests/s390x/stfle.vgtest      |    2 +-
 none/tests/s390x/vector.c          | 1997 ++++++++++++++++++++++++++++
 none/tests/s390x/vector.h          |  139 ++
 none/tests/s390x/vector.stderr.exp |    2 +
 none/tests/s390x/vector.stdout.exp |   86 ++
 none/tests/s390x/vector.vgtest     |    2 +
 tests/s390x_features.c             |   58 +-
 31 files changed, 7026 insertions(+), 778 deletions(-)

Compared to 54 files changed, 18238 insertions, and 11990 deletions, this is
obviously much smaller and also doesn't contain those deletions and
re-insertions.

The patch still contains various white space corrections that are not
necessarily related to this Bug.  They should probably be separated out.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to