https://bugs.kde.org/show_bug.cgi?id=385867
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kno
| |tifications/588151c5e000969
| |53420bd53a520480c6bc7b115
Resolution|--- |FIXED
--- Comment #1 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 588151c5e00096953420bd53a520480c6bc7b115 by David Edmundson.
Committed on 19/10/2017 at 16:14.
Pushed by davidedmundson into branch 'master'.
Remove check for SNI hosts when chosing whether to use legacy mode
Summary:
Previous code (since very first commit) checked for both having a valid
KSNI watcher as well as making sure there was a host available in order
to choose which mode to use.
This made some sense when Plasma 4 still had proper xembed support and
one could turn SNIs off.
The current code here is broken. On first creation we only check for a
watcher - and only ends up checking for the host if it changes at
runtime.
Given it's not working properly, and the use case has changed it seems
we can safely remove this code.
This removes a blocking DBus call on the property.
Reviewers: graesslin
Reviewed By: graesslin
Subscribers: graesslin, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8354
M +0 -10 src/kstatusnotifieritem.cpp
M +0 -1 src/kstatusnotifieritem.h
https://commits.kde.org/knotifications/588151c5e00096953420bd53a520480c6bc7b115
--
You are receiving this mail because:
You are watching all bug changes.
