https://bugs.kde.org/show_bug.cgi?id=384481

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-integration/1781d60b230
                   |                            |c32977c078e2943d94c506d7ee6
                   |                            |45
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 1781d60b230c32977c078e2943d94c506d7ee645 by David Edmundson.
Committed on 22/09/2017 at 15:14.
Pushed by davidedmundson into branch 'Plasma/5.11'.

Set QtQuickControls theme in QPT

Summary:
Currently we set QT_QUICK_CONTROLS_STYLE in startkde.

This causes problems as we're setting vars that meddle with other
developers setups. Especially if they're using QGuiApplication which
will instantly crash when using the desktop theme.

By moving the setting inside the QPT we can:
- only affect QApplications
- only affect apps that are desktopSettingsAware

If this env is already explicitly set by someone else, that has
precedence.

Also if this ever does move from being an env variable, we will probably
want to add the code here.
Related: bug 384466

Test Plan:
Unset env
Ran systemsettings5 the scrollbar was the correct colour

Reviewers: #plasma, gladhorn

Reviewed By: #plasma, gladhorn

Subscribers: gladhorn, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7935

M  +15   -0    src/platformtheme/kdeplatformtheme.cpp
M  +1    -0    src/platformtheme/kdeplatformtheme.h

https://commits.kde.org/plasma-integration/1781d60b230c32977c078e2943d94c506d7ee645

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to