[valgrind] [Bug 377698] Missing memory check for futex() uaddr arg for FUTEX_WAKE and FUTEX_WAKE_BITSET, check only 4 args for FUTEX_WAKE_BITSET, and 2 args for FUTEX_TRYLOCK_PI

[Diane M]

https://bugs.kde.org/show_bug.cgi?id=377698

--- Comment #6 from Diane M <diane.meirow...@oracle.com> ---
Julian, I encountered the problem while implementing and testing futex() for
sparc linux.

+      if (VG_(tdict).track_pre_reg_read) {
+         PRA6("futex",int,val3);
+      }

I believe the if is necessary, because it is checking whether the function
pointer is defined, whereas PRA6 eventually invokes this code which actually
calls the function pointed to.

#define PRRAn_LE(n,s,t,a)                          \
   do {                                            \
      Int here = layout->o_arg##n;                 \
      vg_assert(sizeof(t) <= sizeof(UWord));       \
      vg_assert(here >= 0);                        \
      VG_(tdict).track_pre_reg_read(               \
         Vg_CoreSysCall, tid, s"("#a")",           \
         here, sizeof(t)                           \
      );                                           \
   } while (0)

-- 
You are receiving this mail because:
You are watching all bug changes.