https://bugs.kde.org/show_bug.cgi?id=377698
Julian Seward <jsew...@acm.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsew...@acm.org
--- Comment #5 from Julian Seward <jsew...@acm.org> ---
As background, how did you come across this problem? Did you see some
false errors in some test cases, or something like that?
Looks ok to me, except
+ if (VG_(tdict).track_pre_reg_read) {
+ PRA6("futex",int,val3);
+ }
I think the PRA6 call shouldn't be guarded by VG_(tdict).track_pre_reg_read,
since -- as far as I can see -- PRA6 tests that anyway. I see that that's a
pre-existing problem in this syswrap-linux.c, and IMO all of the explicit
checks of VG_(tdict).track_pre_reg_read in this file are redundant.
Please attach patches in files (the "paste text as attachment" option is
convenient, sometimes). This avoids corruption problems. Also, scraping
patches off the web page when it comes time to land them is difficult and
error-prone.
--
You are receiving this mail because:
You are watching all bug changes.
