https://bugs.kde.org/show_bug.cgi?id=357039
Bug ID: 357039
Summary: kwalletmanager5 config module has incomplete
authAction
Product: kwalletmanager
Version: unspecified
Platform: Compiled Sources
OS: All
Status: UNCONFIRMED
Severity: major
Priority: NOR
Component: general
Assignee: va...@kde.org
Reporter: rjvber...@gmail.com
The configuration module of the current kwalletmanager version begins to set up
an authentication action required for saving changes to the wallet
configuration, but fails to add the actual authAction. As a result, saving
becomes impossible because `authAction().isValid == false`.
Reproducible: Always
Steps to Reproduce:
N/A
Actual Results:
authAction.isValid() evaluates to falls, and as a result it is impossible to
save changes to the wallet configuration
Expected Results:
changes to the configuration can be saved
either setAuthAction() is called to define an authentication action, or else
the code setting up an authentication requirement should be stripped like with
the patch below.
--- src/konfigurator/orig.konfigurator.cpp 2015-12-22 01:46:08.000000000
+0100
+++ src/konfigurator/konfigurator.cpp 2015-12-22 01:46:57.000000000 +0100
@@ -60,7 +60,7 @@
QStringLiteral(),
QStringLiteral("stai...@kde.org"));
setAboutData(about);
- setNeedsAuthorization(true);
+ setNeedsAuthorization(false);
QVBoxLayout *vbox = new QVBoxLayout(this);
//PORT QT5 vbox->setSpacing(KDialog::spacingHint());
@@ -267,18 +267,19 @@
QVariantMap args;
KAuth::Action action = authAction();
if (!action.isValid()) {
- qDebug() << "There's no authAction, not saving settings";
- return;
- }
- action.setArguments(args);
+// qDebug() << "There's no authAction, not saving settings";
+// return;
+ } else {
+ action.setArguments(args);
- KAuth::ExecuteJob *j = action.execute();
+ KAuth::ExecuteJob *j = action.execute();
- if (!j->exec()) {
- qDebug() << j->errorText();
- KMessageBox::error(this, j->errorString(), i18n("KDE Wallet Control
Module"));
- load();
- return;
+ if (!j->exec()) {
+ qDebug() << j->errorText();
+ KMessageBox::error(this, j->errorString(), i18n("KDE Wallet
Control Module"));
+ load();
+ return;
+ }
}
KConfigGroup config(_cfg, "Wallet");
--
You are receiving this mail because:
You are watching all bug changes.
