Thanks all, I've merged the PR. Agreed, this doesn't preclude converting notebooks to XML, but we probably wouldn't use the removed code for that anyway. And we can always resurrect this code if we realise that it is useful for something.
On Tue, 12 Feb 2019 at 08:16, Fernando Perez <[email protected]> wrote: > +1 for removal - I think that if/when we tackle the problem of publishers, > a cleaner approach would probably be to output XML versions of notebook > content strictly tailored to their data/metadata schemas (and thus not > meant for *ingestion* by Jupyter, only as output). > > On Mon, Feb 11, 2019 at 11:43 PM Chris Holdgraf <[email protected]> > wrote: > >> The only major potential stakeholder that (I think) still cares about XML >> is large-scale publishers, but I don't think there's been any official >> adoption of Jupyter Notebooks there anyway, so it's probably fine. Thanks >> for bringing this up Thomas! I'm +1 as well! >> >> On Mon, Feb 11, 2019 at 2:27 PM Brian Granger <[email protected]> >> wrote: >> >>> +1 >>> >>> On Mon, Feb 11, 2019 at 1:41 PM Matthew Seal <[email protected]> wrote: >>> >>>> I'm 100% for removing -- I can't think of any recent tools that even >>>> support xml. Thanks for making the PR! >>>> >>>> On Mon, Feb 11, 2019 at 7:01 AM Thomas Kluyver <[email protected]> >>>> wrote: >>>> >>>>> Hi all, >>>>> >>>>> Way back in 2011, when the first version of the IPython Notebook was >>>>> being written, there was an option to store notebooks as XML. JSON was >>>>> chosen as the default, and has always been the format all of our >>>>> applications use. However, the code to read XML files stayed around, and >>>>> recently Danor Cohen pointed out that it is vulnerable to denial of >>>>> service >>>>> attacks. >>>>> >>>>> I am proposing to *remove this code* rather than maintain it. None of >>>>> our applications call it, and I'm not aware of anyone else using it. The >>>>> XML format is, as far as I know, an abandoned concept. >>>>> >>>>> If you are using that code (nbformat.v2.*_xml), and you can't >>>>> practically move away from it, now would be a good time to take over >>>>> maintenance of it. ;-) >>>>> >>>>> The removal PR is here: https://github.com/jupyter/nbformat/pull/133 >>>>> >>>>> Thanks, >>>>> Thomas >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Project Jupyter" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To post to this group, send email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jupyter/CAOvn4qh_0JMrZTLweN21eTxKX54q6uy7O%2BErWc6i2PQ8f3r3BA%40mail.gmail.com >>>>> <https://groups.google.com/d/msgid/jupyter/CAOvn4qh_0JMrZTLweN21eTxKX54q6uy7O%2BErWc6i2PQ8f3r3BA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Project Jupyter" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To post to this group, send email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jupyter/CAJF6vz7pOa0DAP%3DKxjhbHUtA4T5ZG1f3jDoduQhj-GywVvK22w%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/jupyter/CAJF6vz7pOa0DAP%3DKxjhbHUtA4T5ZG1f3jDoduQhj-GywVvK22w%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> -- >>> Brian E. Granger >>> Associate Professor of Physics and Data Science >>> Cal Poly State University, San Luis Obispo >>> @ellisonbg on Twitter and GitHub >>> [email protected] and [email protected] >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Project Jupyter" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jupyter/CAH4pYpRKyEKjuNkQ-QR43%3D72cp3AEAt14Fq1Kn8hvYBNXoEDNw%40mail.gmail.com >>> <https://groups.google.com/d/msgid/jupyter/CAH4pYpRKyEKjuNkQ-QR43%3D72cp3AEAt14Fq1Kn8hvYBNXoEDNw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Project Jupyter" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jupyter/CAD7kTDHdvKppDpbeOfxJaD42F2q0aGWXsFimAgtA9vg6hNYYyQ%40mail.gmail.com >> <https://groups.google.com/d/msgid/jupyter/CAD7kTDHdvKppDpbeOfxJaD42F2q0aGWXsFimAgtA9vg6hNYYyQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > > -- > Fernando Perez (@fperez_org; http://fperez.org) > fperez.net-at-gmail: mailing lists only (I ignore this when swamped!) > fernando.perez-at-berkeley: contact me here for any direct mail > > -- > You received this message because you are subscribed to the Google Groups > "Project Jupyter" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jupyter/CAHAreOqNKX0u0e8h_jJwikFonMqWdaP%2B8jKCVKSmWWsC_-bW7Q%40mail.gmail.com > <https://groups.google.com/d/msgid/jupyter/CAHAreOqNKX0u0e8h_jJwikFonMqWdaP%2B8jKCVKSmWWsC_-bW7Q%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Project Jupyter" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/CAOvn4qiv-wAHw9ASxFFikitdnNQ%2Bfm5Up0tYRFJuQ0vpFX9k7g%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
