I'm 100% for removing -- I can't think of any recent tools that even support xml. Thanks for making the PR!
On Mon, Feb 11, 2019 at 7:01 AM Thomas Kluyver <[email protected]> wrote: > Hi all, > > Way back in 2011, when the first version of the IPython Notebook was being > written, there was an option to store notebooks as XML. JSON was chosen as > the default, and has always been the format all of our applications use. > However, the code to read XML files stayed around, and recently Danor Cohen > pointed out that it is vulnerable to denial of service attacks. > > I am proposing to *remove this code* rather than maintain it. None of our > applications call it, and I'm not aware of anyone else using it. The XML > format is, as far as I know, an abandoned concept. > > If you are using that code (nbformat.v2.*_xml), and you can't practically > move away from it, now would be a good time to take over maintenance of it. > ;-) > > The removal PR is here: https://github.com/jupyter/nbformat/pull/133 > > Thanks, > Thomas > > -- > You received this message because you are subscribed to the Google Groups > "Project Jupyter" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jupyter/CAOvn4qh_0JMrZTLweN21eTxKX54q6uy7O%2BErWc6i2PQ8f3r3BA%40mail.gmail.com > <https://groups.google.com/d/msgid/jupyter/CAOvn4qh_0JMrZTLweN21eTxKX54q6uy7O%2BErWc6i2PQ8f3r3BA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Project Jupyter" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/CAJF6vz7pOa0DAP%3DKxjhbHUtA4T5ZG1f3jDoduQhj-GywVvK22w%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
