On 02.07.2024 09:20, János Tamás Kis wrote:
Hi,
This is great! THX! 😊
np.
I tried it and I have some question:
1. during project import, when I specify the Local Destination, is it necessary set to
"Clone submodules" and what can it does if I set it?
not needed. we do not have any maven submodules in OJ
2. at the "Program Arguments" setting you wrote "- I18n en_US" but there is an
unnecessary space, what throw an error, when I copied it, so you need correct to this: "-I18n en_US"
i copied this verbatim from the wiki page
-default-plugins scripts\default-plugins.xml -extensions-directory "lib\ext" -extensions-directory
"target\lib.ext.core" -extensions-directory "target\lib.ext.plus" -I18n en_US -v info
no superfluous space there. maybe some copy/paste error?
3. the OJ / Plugins / Map Coloring menuitem is displayed incorrectly in
Hungarian (probably it is a character encoding error in the
mapcolorstrings_hu.properties file). Where can this be fixed? (I couldn't find
the ojmapcoloring-0.5.2.jar...)
should be this extension
https://github.com/openjump-gis/five-color-extension/blob/main/src/main/resources/org/freevoice/mapcoloring/language/jump_hu.properties
file looks good. maybe encoding is not UTF8 in maven pom. nope it is
https://github.com/openjump-gis/five-color-extension/blob/main/pom.xml
but file jump_hu.properties encoding is ANSI though. that might be the cause,
shouldn't because ANSI is part of UTF8. ok tried, that's not it either.
can you confirm that the file looks good on github?
4. if I update the jump_hu.properties file for example, how can pull it to
github? (I know, I have serious shortcomings in java, eclipse, git, etc...)
you probably mean push. and yes, kinda. what contributors usually do is they
fork a repo on github, clone that locally, commit the changes and push those to
their fork. after that they start a Pull Request on github and the change may
be refined and merged then.
small things like language may also be edited on github directly or provided as
plain files. we can commit those as well.
hope that helped.. ede
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
