Peppe, do you to want try again after the restore?
..ede On 22.06.2018 14:22, Giuseppe Aruta wrote: > I will revomove the patch. The icon comes from Kosmo SAIG > > 2018-06-22 14:09 GMT+02:00 <edgar.sol...@web.de <mailto:edgar.sol...@web.de>>: > > ohh, > > and Logger.error() in the catch should be implemented for the kind > developer to be notified in case of an error. > > ..ede > > On 22.06.2018 14:07, edgar.sol...@web.de <mailto:edgar.sol...@web.de> > wrote: > > Peppe, > > > > apart from the fact that you reformatted the whole class (again!) with > 4spaces indention an wrongly broken comments, you simply replaced the method > icon() . > > > > that is wrong! the method used allover this class is getIcon(url), > which would be the right place to apply your patch. > > > > the default icon is fine. where did you get it from? > > > > ..ede > > > > On 22.06.2018 13:59, Giuseppe Aruta wrote: > >> I applied the patch on OJ 5821 > >> The default icon (in case the choosen one doesn't exist) is the > following: > >> > >> > >> > >> > >> 2018-06-22 13:52 GMT+02:00 Giuseppe Aruta <giuseppe.ar...@gmail.com > <mailto:giuseppe.ar...@gmail.com> <mailto:giuseppe.ar...@gmail.com > <mailto:giuseppe.ar...@gmail.com>>>: > >> > >> Hi Ede,Michale > >> ther are actually 3 Iconloader in OJ > >> 1) com.vividsolutions.jump.workbench.ui.images.IconLoader - The > main class, widely used in OJ > >> 2) com.vividsolutions.jump.workbench.ui.images.famfam.IconLoader - > which it is actually used by 2 plugins: CopyImagePlugIn and > CutSelectedItemsPlugIn > >> 3) org.openjump.core.ui.images.IconLoader - which is used by at > least 30/32 plugins (CopySelectedItemsPlugIn, CombineSelectedFeaturesPlugIn, > etc) > >> > >> Peppe > >> > >> 2018-06-22 11:02 GMT+02:00 <edgar.sol...@web.de > <mailto:edgar.sol...@web.de> <mailto:edgar.sol...@web.de > <mailto:edgar.sol...@web.de>>>: > >> > >> On 22.06.2018 09:09, Michaël Michaud wrote: > >> > Making IconLoader more robust is a good idea. Note that we > have several IconLoader in the distribution (plus some included in > extensions), but maybe we can try to use some kind of heritage to implement > it only once. > >> > >> i seem to remember to have unified at least JUMP & OJ > iconloaders somewhat in the past, so they use the same code or such.. ede > >> > >> > ------------------------------------------------------------------------------ > >> Check out the vibrant tech community on one of the world's most > >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> _______________________________________________ > >> Jump-pilot-devel mailing list > >> Jump-pilot-devel@lists.sourceforge.net > <mailto:Jump-pilot-devel@lists.sourceforge.net> > <mailto:Jump-pilot-devel@lists.sourceforge.net > <mailto:Jump-pilot-devel@lists.sourceforge.net>> > >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel> > <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>> > >> > >> > >> > >> > >> > >> > ------------------------------------------------------------------------------ > >> Check out the vibrant tech community on one of the world's most > >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> > >> > >> > >> _______________________________________________ > >> Jump-pilot-devel mailing list > >> Jump-pilot-devel@lists.sourceforge.net > <mailto:Jump-pilot-devel@lists.sourceforge.net> > >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel> > >> > > > > > > > ------------------------------------------------------------------------------ > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > _______________________________________________ > > Jump-pilot-devel mailing list > > Jump-pilot-devel@lists.sourceforge.net > <mailto:Jump-pilot-devel@lists.sourceforge.net> > > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel> > > > > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
