Hi,

I'm no more familiar with eclipse, but I think recent versions come with maven bundled.

If you have maven installed, it comes with a number of "goals" or "targets"

https://books.sonatype.com/m2eclipse-book/reference/running-sect-running-maven-builds.html

If you use package target (i.e. Run as... "Maven package" according to the screenshot), it should build a complete OpenJUMP bundle on your computer the same it is done in official releases.

Making IconLoader more robust is a good idea. Note that we have several IconLoader in the distribution (plus some included in extensions), but maybe we can try to use some kind of heritage to implement it only once.

Michaël


Le 22/06/2018 à 08:15, Giuseppe Aruta a écrit :
Hi Michael,
thanks for taking care. Indeed I am a little confused as I am not familiar with maven.

ProfileUtils - I deprecated that class as it has been substituted by othe classes. I made the correction for the missing icon

Missing icons - I found that Kosmo solved the proble using a method that substitutes a missing icon with a generic one.
In OpenJUMP basically this mwthod:

 public static ImageIcon icon(String filename) {
    return getIcon(IconLoader.class.getResource(resolveFile(filename)));
  }


can be substituted with this:


//A generic icon (in Kosmo is a red question marker image)
   public final static ImageIcon DEFAULT_UNKNOW_ICON = new ImageIcon(
            IconLoader.class.getResource("default_icon.png"));

//Check the icon otherwise change with the generic one
    public static ImageIcon icon(String filename) {
        ImageIcon icon = null;
        try {
            icon = getIcon(IconLoader.class.getResource(resolveFile(filename)));
        } catch (final Exception e) {
            icon = DEFAULT_UNKNOW_ICON;
        }
        return icon;
    }

2018-06-21 22:24 GMT+02:00 Michaël Michaud <m.michael.mich...@orange.fr <mailto:m.michael.mich...@orange.fr>>:

    Hi Peppe,

    I partly fixed your last commit.

    Please check that the change I made in ProfileUtils line 340 is
    OK, and commit missing resources (ex. fugue/clock.png)

    You should check that the project compile before committing.
    Missing resources like icons are more difficult to detect until
    you package the project with maven and test it (I also often
    forgot to commit an icon).

    Michaël


    
------------------------------------------------------------------------------
    Check out the vibrant tech community on one of the world's most
    engaging tech sites, Slashdot.org! http://sdm.link/slashdot
    _______________________________________________
    Jump-pilot-devel mailing list
    Jump-pilot-devel@lists.sourceforge.net
    <mailto:Jump-pilot-devel@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
    <https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to