Larry, Jukka, i just committed jts 1.14 snapshot to OJ trunk. could one of you please check if the spatialite multigeometry bug has vanished finally?
happy holidays.. ede On 23.12.2013 04:40, Martin Davis wrote: > Thanks, Larry. Patch is commited. > > Martin > > > On Sun, Dec 22, 2013 at 9:22 AM, Larry Reeder <lnree...@gmail.com > <mailto:lnree...@gmail.com>> wrote: > > Martin, I've attached a patch for WKBReader that uses the initial > endian flag for multigeometries and ignores the flag for contained geometries > if the endianness flag is something besides the XDR/NDR flags. The patch > also includes a test case that use multigeometries exported from the > Spatialite internal BLOB format. > > The patch was made against a recent checkout of JTS 1.14 from the > Sourceforge SVN. Can you apply to the JTS trunk? Let me know if you'd like > me to submit it in some other way. > > Thanks........... lreeder > > > > > On Mon, Dec 2, 2013 at 4:12 PM, Martin Davis <mtncl...@gmail.com > <mailto:mtncl...@gmail.com>> wrote: > > That strategy still makes sense to me. > > M > > > On Mon, Dec 2, 2013 at 2:51 PM, Larry Reeder <lnree...@gmail.com > <mailto:lnree...@gmail.com>> wrote: > > Now that cold is here, I've got more time to stay indoors and > code. I'm willing to submit a JTS patch with sample data and unit tests. > > Martin, in implementing the patch, I will be following the > guidance in your suggestion on April 21, 2013: > > " The WKBReader can be changed to only switch endianess when > the code is one of the two specified in the standard (0 = > BigEndian, 1 = > LittleEndian). If any other code is read then the endianess will > be left > unchanged. That should handle the SpatialLite BLOB format, > right? And > it avoids any explicit dependency on magic numbers from > SpatialLite. > And it still allows switching endianness mid-WKB, as per the > standard, > should anyone be so perverse as to do that." > > Let me know if you see any problems there. > > Thanks........... lreeder > > > On Mon, Dec 2, 2013 at 3:39 PM, Martin Davis <mtncl...@gmail.com > <mailto:mtncl...@gmail.com>> wrote: > > I have very little time to look at this by year-end, I'm > afraid. > > Did someone have code to commit for fixing this? (with > sample data for unit tests) ? > > > > > On Mon, Dec 2, 2013 at 1:30 PM, <edgar.sol...@web.de > <mailto:edgar.sol...@web.de>> wrote: > > On 02.12.2013 22:11, Rahkonen Jukka wrote: > > Hi, > > > > We have many exciting new features and I suppose we > will have a great new OpenJUMP 1.7 rather soon. It would be excellent to have > a well working Spatialite support in OJ 1.7 Plus through DB Query plugin, but > the issue with reading multigeometries remains [1]. Martin almost promised to > make a fix into JTS [2] but I do not see such a commit in the JTS code [3]. > The best I can hope to happen is to get the fix into the new BSD/EPL licensed > JTS release [4] but perhaps Martin is busy with other things and that will > not happen. > > > > Do we have other alternatives for making the DB Query > plugin to work well with Spatialite on current OJ than flipping in the old > JTS version when Spatialite support is on a wishlist? Taking an old > jts-1.12.jar and renaming it into jts-1.13.jar makes the plugin happy but > probably breaks some cool new stuff and is thus a poor workaround. > > > > [1] http://sourceforge.net/p/jts-topo-suite/bugs/36/ > > [2] > http://sourceforge.net/p/jts-topo-suite/mailman/message/31118630/ > > [3] > http://sourceforge.net/p/jts-topo-suite/code/commit_browser > > [4] > http://sourceforge.net/p/jts-topo-suite/mailman/message/31422827/ > > > > i already proposed an alternative, > > http://comments.gmane.org/gmane.comp.java.jts.topo-suite.user/6 > > but Larry wanted to wait for Martin.. > @Larry, Martin: what's your take on this nearing the end > of this year? > > ..ede > > > > > > ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
