Hi, I just had a quick look to the first two patches. I could understand the benefit of doing these changes. I have no postgresql/postgis set on my computer at the moment, and cannot do any test. But if you can confirm you did some tests with a real database and if nobody can do further tests, I would be pleased to commit.
@others : just to make sure : the second patch keeps the original postgresql name of the geometry column instead of giving to it the explicit name "GEOMETRY". It should be ok as Attribute Name and attribute Type are two different things, but if anyone knows about a reason or a case where the geometry attribute name should be "GEOMETRY", let me know @jakko : I have one more suggestion about this part of the code. I noticed that *asbinary* could only read 2D geometries, while *asewkb* could read 3D geometry. Are you aware of any drawback if we change asbinary to asewkb ? For the third patch, I hope somebody else will be able to do a quick review. Michaël Sunburned Surveyor a écrit : > Thank you for your contributions. I'm afraid we may not have anyone > familiar enought with the postgis plug-ins in OpenJUMP to provide a > very useful review of your code. We may just have to commit them! As > long as they don't break anything we should be in good shape. > > We probably do have someone that can take care of a review of the WMS > patch. Let's see if anyone responds. > > Thanks again for your contributions. I hope we will hear more from you. > > The Sunburned Surveyor > > P.S. - Can one of our programmers point out a quick how-to on applying > a patch file with SVN. Can it be done from subclipse? > > > On Fri, May 9, 2008 at 4:47 AM, Ruutiainen, Jaakko > <[EMAIL PROTECTED]> wrote: > >> Hi, >> >> I have three patches for OpenJump. I'd appreciate if someone had time to >> review and commit them to the SVN. >> >> postgis_find_extent_schema.patch enables basic use of tables in other than >> public schema. (bug 1694304, at least partly) >> >> postgis_no_geometry_rename.patch removes some unnecessary geometry column >> renaming allowing easier database updating with the separate PostGIS plug-in. >> >> wms_basic_http_auth.patch allows use of WMS servers protected with basic >> HTTP authentication. Credentials are taken from URL, which can be entered as >> 'http://user:[EMAIL PROTECTED]/path' >> >> Best regards >> -- >> Jaakko Ruutiainen >> Logica >> Tel. +358 50 420 3057 >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference >> Don't miss this year's exciting event. There's still time to save $100. >> Use priority code J8TL2D2. >> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone >> _______________________________________________ >> Jump-pilot-devel mailing list >> Jump-pilot-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >> >> >> > > ------------------------------------------------------------------------- > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference > Don't miss this year's exciting event. There's still time to save $100. > Use priority code J8TL2D2. > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > > ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
