dengziming commented on code in PR #12207:
URL: https://github.com/apache/kafka/pull/12207#discussion_r883231041
##########
metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java:
##########
@@ -280,7 +261,16 @@ public void testDowngradeMetadataVersion() {
Collections.emptyMap(),
true);
assertEquals(Errors.INVALID_UPDATE_VERSION,
result.response().get(MetadataVersion.FEATURE_NAME).error());
- assertEquals("Invalid update version 1 for feature metadata.version.
The quorum does not support the given feature version.",
+ assertEquals("Invalid update version 1 for feature metadata.version.
Local controller 0 only supports versions 4-5",
result.response().get(MetadataVersion.FEATURE_NAME).message());
}
+
+ @Test
+ public void testSetVersion0ForNonexistentFeature() {
+ FeatureControlManager manager = new FeatureControlManager.Builder().
+ build();
+ manager.updateFeatures(Collections.singletonMap("foo",
+ Map<String, FeatureUpdate.UpgradeType> upgradeTypes,
Review Comment:
Is this added by accident?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
