cmccabe commented on code in PR #12207:
URL: https://github.com/apache/kafka/pull/12207#discussion_r883174695
##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -264,11 +265,11 @@ FinalizedControllerFeatures finalizedFeatures(long epoch)
{
}
public void replay(FeatureLevelRecord record) {
- if (!canSupportVersion(record.name(), record.featureLevel())) {
Review Comment:
Yeah.
It's fine to do a sanity check based on local supported versions. Pulling in
the quorum is where it is incorrect (which might be an argument for pulling
`localSupportedFeatures` out of `QuorumFeatures`, but one step at a time.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
