cmccabe commented on code in PR #11969:
URL: https://github.com/apache/kafka/pull/11969#discussion_r868763592
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -725,7 +727,11 @@ object KafkaConfig {
/************* Authorizer Configuration ***********/
val AuthorizerClassNameDoc = s"The fully qualified name of a class that
implements <code>${classOf[Authorizer].getName}</code>" +
- " interface, which is used by the broker for authorization."
+ " interface, which is used by the broker for authorization."
+ val EarlyStartListenersDoc = "A comma-separated list of listener names which
should be started before any non-early start listeners. " +
Review Comment:
> nit: the first sentence is seems circular
Hmm, I don't know -- "started before any non-early-start listeners" does
seem to convey some information. Circular would be more like "early start
listeners are early start listeners," right? :) Maybe I'm misunderstanding your
point.
> I think it would be helpful to mention the authorizer use case.
The second sentence says "This is useful in cases where the startup process
requires some listeners to be open before other listeners can be brought up"
which I thought was stating the use-case... do you have an idea for improving
it?
> Also, can we say something about the default?
Good idea. I added a bit about the default (of controller listeners) at the
end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
