cmccabe commented on code in PR #11969:
URL: https://github.com/apache/kafka/pull/11969#discussion_r868761971
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1509,4 +1512,29 @@ class KafkaConfigTest {
assertNotNull(config.getLong(KafkaConfig.SaslOAuthBearerJwksEndpointRetryBackoffMsProp))
assertNotNull(config.getLong(KafkaConfig.SaslOAuthBearerJwksEndpointRetryBackoffMaxMsProp))
}
+
+ @Test
Review Comment:
> May be useful testing that the default uses the controller listeners?
Sure, I'll add a test.
> As a side comment, I wonder if the default of the controller listeners
should only apply when the standard authorizer is in use? Or perhaps a warning
of some kind if we have a non-standard authorizer and early.start.listeners is
not set.
Hmm... it's not clear. If you're using the ZK-based authorizer, setting
`early.start.listeners` neither helps nor hurts you.
In theory, anyone could write an `Authorizer` and implement this setting, so
it's hard to warn about configurations that the hypothetical authorizer might
or might not use. This is one of the usability taxes that all pluggable things
impose on us...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
