LiamClarkeNZ commented on pull request #11475: URL: https://github.com/apache/kafka/pull/11475#issuecomment-1074783688
Hi Luke, Ismael et al, No worries on adding a comment to that effect in the upgrade docs - but I'm not sure how to word it, as the idempotent producer was never explicitly disabled by default in the Kafka Connect Worker. I realise, based on Luke's recent work to fix KAFKA-13598, that the intended enabling of idempotence by default with Kafka 3.0 didn't happen either. So while I just removed the setting of max inflight requests to 1, allowing the default of 5 to be used, . (I also removed the explicit setting of acks=all for the same reason), I guess this will be the first version where Kafka Connect uses idempotent producers by default. So I was thinking of wording it like this? *Kafka Connect now uses [idempotent producers](http://link.to.docs.here <http://link.to.docs.here>) by default, and now defaults to a maximum of 5 inflight requests (five is the uppermost limit supported by idempotent producers). You can override producer settings controlling this behaviour using the properties producer.enable.idempotence and producer.max.inflight.requests* Actually, do we need to add similar documentation to the upgrade documentation for 3.0.1, 3.1.1 also? As KC workers based on those version will now be defaulting to idempotent enabled. The workers in those versions will still have max.inflight.requests set to 1, but it could be set to 5 by producer.* overrides, I could add commentary to that regard. Thanks, Liam On Tue, 22 Mar 2022 at 19:07, Luke Chen ***@***.***> wrote: > @kkonstantine <https://github.com/kkonstantine> , thanks for the comment. > I agree we add comments in the code to say the idempotent producer is > enabled by default. > cc @LiamClarkeNZ <https://github.com/LiamClarkeNZ> > > Thank you. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/kafka/pull/11475#issuecomment-1074774576>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC2Q2JGE4E2XYPJ5LINUMNDVBFPQDANCNFSM5HRTSEYA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
