kkonstantine edited a comment on pull request #11475: URL: https://github.com/apache/kafka/pull/11475#issuecomment-1074761446
Thanks for bring this to our attention @ijuma. This change should be fine from Connect's perspective. `acks=all` is now implied instead of explicitly defined and idempotence has been enabled since 3.0.0 and we had decided not to override this setting in Connect. The property that would give someone pause is the value for `max.in.flight.requests.per.connection` that now is greater than 1. The reassurance that this will work comes from [KAFKA-5494](https://issues.apache.org/jira/browse/KAFKA-5494) which unfortunately is not mentioned in the original [KIP-98](https://cwiki.apache.org/confluence/display/KAFKA/KIP-98+-+Exactly+Once+Delivery+and+Transactional+Messaging) (I see it mentioned in the [KIP-318](https://cwiki.apache.org/confluence/display/KAFKA/KIP-318%3A+Make+Kafka+Connect+Source+idempotent) that is relevant to Connect) and should have been mentioned in this PR, if not in the code. Having said that, I think it would have been a good idea to leave a comment in the code that would say that Connect requires these configs which are now enabled by default with the idempotent producer. I also agree that this should go as a notable change in the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
