cmccabe commented on pull request #11503: URL: https://github.com/apache/kafka/pull/11503#issuecomment-975815825
@rondagostino : I think we need to discuss the question of whether to include `controller.listener.names` in `listener.names` a bit more. The case for including it: 1. When running in combined mode, it must be included. So if we forbid it in standalone mode, it makes it harder to switch between these modes. This would actually be the first major config divergence between standalone mode and combined mode -- currently, no other configs need to be different aside from `process.roles`. 2. Changing this is incompatible. (This isn't a deal-breaker because 3.0 / 3.1 were Preview releases for KRaft. But it is something to consider) 3. I THINK there are a bunch of cases where we assume that all the listeners are in "listeners". So some code changes are probably required. This is the least important point, of course -- we can just put in the work if we want. The case for forbidding it: 4. It's confusing to have things in "listeners" that are not actually listeners for the current node. A third option is to leave it as a "don't care," as it is now: you can include it, but it will be ignored, possibly with a warning. The warning option is not very enticing. We already have lots of warnings that are ignored, and it seems certain that this would become another one. Overall I would lean towards keeping it out of "listeners," but I'm curious what you think. Whatever we do, we need more tests of these configs... (thanks for adding more in this PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
