showuon commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-965218735
@guozhangwang , thanks for the comments and clear explanation.
> When we add the generation id to the join group protocol, it means the
response could also include UNKNOWN_MEMBER_ID as well:
UNKNOWN_MEMBER_ID in JoinGroup: reset both.
I think you're trying to say `ILLEGAL_GENERATION in JoinGroup: reset
generation only.` here, not `UNKNOWN_MEMBER_ID`, right? :)
I've updated the KIP to add more detailed implementation you suggested.
And for `reset generation only, and keep member ID` change, I agree. It
makes sense to me. I've updated the PR, and waiting for the jenkins build
result to see if this change breaks any tests. You can check if this is what
you expected.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
