guozhangwang commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-948839504
Hi @vamossagar12 @ableegoldman I took a quick look at the PR and I have a few questions: * The fix itself seems to be applied only to persistent stores (built-in or customized), and not in-memory, assuming the latter has done its duties. But for customized in-memory stores it may not be the case. Is that right? * I'm a it concerned about applying the filter logic at the metered store, for its complexity introduced. Instead, I'm wondering if we could enforce the retention period restriction into the inner store, i.e. 1) the built-in stores, at the `segmented store` layer would enforce this rule based on its observed stream time, and 2) we just assume customized stores themselves would enforce this rule, and hence do not have the second guard at the outer meteredStore layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
