vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-948851456
@guozhangwang 1) The in memory default state stores already does the filtering. Original thought was to make the Persistent Store be able to also enforce the same retention and hence the checks everywhere that you see. 2) The idea of adding in MeteredStore was that the enforcement would be applicable to any custom store that's implemented. But turns out, it isn't that simple( I realised it after so many code changes lol). For persistent stores, we could push it down to the inner segmented stores(similar to how the in-memory stores do it today). If we can assume that custom state stores would take care of it, then no point having it in Metered store which goes against the original idea but should be ok IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
