showuon commented on a change in pull request #11100:
URL: https://github.com/apache/kafka/pull/11100#discussion_r673833045
##########
File path: docs/streams/developer-guide/dsl-api.html
##########
@@ -3208,14 +3208,13 @@ <h5><a class="toc-backref" href="#id34">KTable-KTable
Foreign-Key
import org.apache.kafka.streams.kstream.TimeWindows;
// A tumbling time window with a size of 5 minutes (and, by definition, an
implicit
-// advance interval of 5 minutes). Note the explicit grace period, as the
current
-// default value is 24 hours, which may be larger than needed for smaller
windows.
-Duration windowSizeMs = Duration.ofMinutes(5);
-Duration gracePeriodMs = Duration.ofMinutes(1);
-TimeWindows.of(windowSizeMs).grace(gracePeriodMs);
+// advance interval of 5 minutes).
+Duration windowSize = Duration.ofMinutes(5);
+Duration gracePeriod = Duration.ofMinutes(1);
Review comment:
Make sense! Added 1 minute grace period comment:
`A tumbling time window with a size of 5 minutes (and, by definition, an
implicit advance interval of 5 minutes), and grace period of 1 minute.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
