showuon commented on a change in pull request #11100:
URL: https://github.com/apache/kafka/pull/11100#discussion_r673731818
##########
File path: docs/streams/developer-guide/dsl-api.html
##########
@@ -3164,9 +3164,9 @@ <h5><a class="toc-backref" href="#id34">KTable-KTable
Foreign-Key
// A hopping time window with a size of 5 minutes and an advance interval of 1
minute.
// The window's name -- the string parameter -- is used to e.g. name the
backing state store.
-Duration windowSizeMs = Duration.ofMinutes(5);
-Duration advanceMs = Duration.ofMinutes(1);
-TimeWindows.of(windowSizeMs).advanceBy(advanceMs);</code></pre>
+Duration windowSize = Duration.ofMinutes(5);
+Duration advance = Duration.ofMinutes(1);
+TimeWindows.ofSizeWithNoGrace(windowSize).advanceBy(advance);</code></pre>
Review comment:
These should be Duration type variable, not `Long` type to represent ms
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
