showuon commented on a change in pull request #10838:
URL: https://github.com/apache/kafka/pull/10838#discussion_r654720550
##########
File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala
##########
@@ -154,7 +156,7 @@ class DynamicConfigManager(private val zkClient:
KafkaZkClient,
}
private val configChangeListener = new
ZkNodeChangeNotificationListener(zkClient,
ConfigEntityChangeNotificationZNode.path,
- ConfigEntityChangeNotificationSequenceZNode.SequenceNumberPrefix,
ConfigChangedNotificationHandler)
+ ConfigEntityChangeNotificationSequenceZNode.SequenceNumberPrefix,
ConfigChangedNotificationHandler, changeExpirationMs, time)
Review comment:
So far, we only use dynamicConficManager during broker started. So, we
can keep as before and use default one for sure. But pass these parameters to
make is more flexible is not bad, either. I don't have any preference here.
What do you think?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
