jlprat commented on a change in pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#discussion_r648867754
##########
File path:
streams/src/main/java/org/apache/kafka/streams/StoreQueryParameters.java
##########
@@ -25,8 +25,8 @@
*/
public class StoreQueryParameters<T> {
- private Integer partition;
- private boolean staleStores;
+ private final Integer partition;
+ private final boolean staleStores;
Review comment:
As far as I can see, these fields are only assigned at constructor, and
are never modified. Being this, together with in place initialization, the only
valid patterns for final fields.
Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
