[GitHub] [kafka] kowshik commented on a change in pull request #10742: MINOR: Add log identifier/prefix printing in Log layer static functions

[GitBox]

kowshik commented on a change in pull request #10742:
URL: https://github.com/apache/kafka/pull/10742#discussion_r636623604



##########
File path: core/src/main/scala/kafka/log/LogLoader.scala
##########
@@ -67,7 +67,7 @@ case class LoadLogParams(dir: File,
                          maxProducerIdExpirationMs: Int,
                          leaderEpochCache: Option[LeaderEpochFileCache],
                          producerStateManager: ProducerStateManager) {
-  val logIdentifier: String = s"[LogLoader partition=$topicPartition, 
dir=${dir.getParent}]"
+  val logIdentifier: String = s"[LogLoader partition=$topicPartition, 
dir=${dir.getParent}] "

Review comment:
       This is required because the existing identifier in the `Log` class is 
suffixed with a whitespace, see: 
https://github.com/apache/kafka/blob/5d4f9f917c8dc356a2d922980ba8101e0f2e7093/core/src/main/scala/kafka/log/Log.scala#L280.
   I'm adding a whitespace here to be consistent with what we already have in 
the code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org