[GitHub] [kafka] showuon commented on a change in pull request #10742: MINOR: Add log identifier/prefix printing in Log layer static functions

[GitBox]

showuon commented on a change in pull request #10742:
URL: https://github.com/apache/kafka/pull/10742#discussion_r636598563



##########
File path: core/src/main/scala/kafka/log/LogLoader.scala
##########
@@ -67,7 +67,7 @@ case class LoadLogParams(dir: File,
                          maxProducerIdExpirationMs: Int,
                          leaderEpochCache: Option[LeaderEpochFileCache],
                          producerStateManager: ProducerStateManager) {
-  val logIdentifier: String = s"[LogLoader partition=$topicPartition, 
dir=${dir.getParent}]"
+  val logIdentifier: String = s"[LogLoader partition=$topicPartition, 
dir=${dir.getParent}] "

Review comment:
       Why do you add a space here, and remove the space in the following log 
content?

##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2225,13 +2225,15 @@ object Log extends Logging {
    * @param dir The directory in which the log will reside
    * @param topicPartition The topic partition
    * @param logDirFailureChannel The LogDirFailureChannel to asynchronously 
handle log dir failure
-   * @param recordVersion The record version
+   * @param recordVersion The record

Review comment:
       Is it intended to change the `The record version` to `The record`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org