[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312721#comment-17312721 ]
Justin Mclean commented on KAFKA-12593: --------------------------------------- In general: - If the work was done at the ASF it should use ASF headers and not have a copyright line and you should not add anything to NOTICE. [1] - If the work come in as an SGA then it should be use the ASF header without a copyright line and the copyright line relocated to the NOTICE file. - If the work is 3rd party file then it should keep the original header including the copyright, unless significant changes are made to it [2] In this case I think it does make sense to replace the headers with a standard ASF ones and re locate the copyright to the NOTICE file. 1. https://www.apache.org/legal/src-headers.html#headers 2. https://www.apache.org/legal/src-headers.html#3party > The Streams-Scala contains the wrong license header > --------------------------------------------------- > > Key: KAFKA-12593 > URL: https://issues.apache.org/jira/browse/KAFKA-12593 > Project: Kafka > Issue Type: Bug > Reporter: John Roesler > Assignee: John Roesler > Priority: Blocker > Fix For: 2.8.0, 2.7.1, 2.6.2 > > > Thanks to [~jmclean] for raising this issue in the mailing list thread: > [https://lists.apache.org/thread.html/r2df54c11c10d3d38443054998bc7dd92d34362641733c2fb7c579b50%40%3Cdev.kafka.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)