kowshik commented on a change in pull request #10430:
URL: https://github.com/apache/kafka/pull/10430#discussion_r603682389
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2454,12 +2444,13 @@ class Log(@volatile private var _dir: File,
private[log] def addSegment(segment: LogSegment): LogSegment =
this.segments.put(segment.baseOffset, segment)
private def maybeHandleIOException[T](msg: => String)(fun: => T): T = {
+ if (logDirFailureChannel.hasOfflineLogDir(parentDir)) {
+ throw new KafkaStorageException(s"The log dir $parentDir is offline due
to a previous IO exception.")
+ }
try {
- checkForLogDirFailure()
fun
} catch {
case e: IOException =>
- logDirOffline = true
logDirFailureChannel.maybeAddOfflineLogDir(dir.getParent, msg, e)
Review comment:
Done, good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
