kowshik opened a new pull request #10430:
URL: https://github.com/apache/kafka/pull/10430


   **This PR is a precursor to the recovery logic refactor work (KAFKA-12553).**
   
   I have made a change to eliminate `Log. isLogDirOffline` attribute. This 
attribute was added in https://github.com/apache/kafka/pull/9676. But it is 
redundant and can be eliminated in favor of looking up `LogDirFailureChannel` 
to check if the `logDir` is offline. The performance implication of such a hash 
map lookup inside `LogDirFailureChannel` should be low/none because 
`ConcurrentHashMap` reads are usually lock free.
   
   **Tests:**
   Relying on existing unit/integration tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to