jsancio commented on a change in pull request #10253:
URL: https://github.com/apache/kafka/pull/10253#discussion_r587635154
##########
File path: metadata/src/main/java/org/apache/kafka/metalog/MetaLogManager.java
##########
@@ -50,13 +50,30 @@
* offset before renouncing its leadership. The listener should determine
this by
* monitoring the committed offsets.
*
- * @param epoch The controller epoch.
- * @param batch The batch of messages to write.
+ * @param epoch the controller epoch
+ * @param batch the batch of messages to write
Review comment:
These are phrases hence no period. For example none of the javadoc for
the Java library have periods.
I only modified the javadoc that I needed to update to not distract from the
PR. We should do another pass and fix all of the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
