mumrah commented on a change in pull request #10253:
URL: https://github.com/apache/kafka/pull/10253#discussion_r587598524
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java
##########
@@ -69,7 +69,12 @@
results.put(entry.getKey(), updateFeature(entry.getKey(),
entry.getValue(),
downgradeables.contains(entry.getKey()), brokerFeatures,
records));
}
- return new ControllerResult<>(records, results);
+
+ if (records.isEmpty()) {
Review comment:
Any reason why we are calling the non-atomic method for an empty record
set? Seems like we don't bother doing this in the other control manager
classes. Can we just do `ControllerResult.atomicOf(records, results)`
regardless of empty records?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
