dajac commented on a change in pull request #10024:
URL: https://github.com/apache/kafka/pull/10024#discussion_r580114449
##########
File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala
##########
@@ -78,6 +77,9 @@ abstract class InterBrokerSendThread(
failExpiredRequests(now)
unsentRequests.clean()
} catch {
+ case _: DisconnectException if isShutdownInitiated =>
+ // DisconnectException is caused by NetworkClient#ensureActive
+ // this thread is closing so this error is acceptable
Review comment:
@chia7712 Could we file a Jira to follow up on @ijuma's point? I think
that we should review this but it is fine to do this separately from this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
