chia7712 commented on a change in pull request #10024:
URL: https://github.com/apache/kafka/pull/10024#discussion_r580104804
##########
File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala
##########
@@ -78,6 +77,9 @@ abstract class InterBrokerSendThread(
failExpiredRequests(now)
unsentRequests.clean()
} catch {
+ case _: DisconnectException if isShutdownInitiated =>
+ // DisconnectException is caused by NetworkClient#ensureActive
+ // this thread is closing so this error is acceptable
Review comment:
> If we would change this in the future, it will be really easy to mis
changing this condition and this could led to a subtile bug like this one
make sense :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
