rondagostino commented on a change in pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#discussion_r571283864
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -352,13 +348,15 @@ class LogManager(logDirs: Seq[File],
val numLogsLoaded = new AtomicInteger(0)
numTotalLogs += logsToLoad.length
- val jobsForDir = logsToLoad.map { logDir =>
+ val jobsForDir = logsToLoad
+ .filter(logDir => Log.parseTopicPartitionName(logDir).topic !=
KafkaRaftServer.MetadataTopic)
Review comment:
We could get rid of the parameter in `startup()` and create a
'TopicLogConfigOverrideRetriever` class that held the `ConfigRepository` and
would retrieve any topic configs in a thread-safe manner -- then we just pass
that to `loadLog()` and it asks for the overrides, and the class would retrieve
iff they haven't been retrieved before. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
