rondagostino commented on a change in pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#discussion_r571274481
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -403,7 +401,30 @@ class LogManager(logDirs: Seq[File],
/**
* Start the background threads to flush logs and do log cleanup
*/
- def startup(): Unit = {
+ def startup(retrieveTopicNames: => Set[String]): Unit = {
+
startupWithTopicLogConfigOverrides(generateTopicLogConfigs(retrieveTopicNames))
Review comment:
Yes, `startup()` is invoked immediately after the instance is
constructed when we are using ZooKeeper, and we can get the configs at that
point since we can just query ZK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
