ableegoldman commented on a change in pull request #9941:
URL: https://github.com/apache/kafka/pull/9941#discussion_r561394151
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -1053,7 +1054,7 @@ int maybeCommitActiveTasksPerUserRequested() {
}
private void commitOffsetsOrTransaction(final Map<Task,
Map<TopicPartition, OffsetAndMetadata>> offsetsPerTask) {
- log.debug("Committing task offsets {}", offsetsPerTask);
+ log.debug("Committing task offsets {}",
offsetsPerTask.entrySet().stream().collect(Collectors.toMap(t ->
t.getKey().id(), Entry::getValue))); // avoid logging actual Task objects
Review comment:
An unrelated but equally annoying thing I noticed in the logs: we should
never log a full `Task` object because it prints literally everything about the
task, including for example the topology description which is not that useful
but sometimes VERY long
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -407,7 +413,7 @@ public static StreamThread create(final
InternalTopologyBuilder builder,
referenceContainer.nextScheduledRebalanceMs,
shutdownErrorHook,
streamsUncaughtExceptionHandler,
- cacheSize -> cache.resize(cacheSize)
Review comment:
Interesting. It *should* be exactly the same, but of course who knows
with Java. Did it cause a test to fail or was it something more subtle?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
