wcarlson5 commented on a change in pull request #9941:
URL: https://github.com/apache/kafka/pull/9941#discussion_r561409907



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -407,7 +413,7 @@ public static StreamThread create(final 
InternalTopologyBuilder builder,
             referenceContainer.nextScheduledRebalanceMs,
             shutdownErrorHook,
             streamsUncaughtExceptionHandler,
-            cacheSize -> cache.resize(cacheSize)

Review comment:
       My ide tried to optimize this as well. At the time not passing in 
cacheSize caused some expections. I would be careful about making this change 
without need




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to