ijuma commented on a change in pull request #9520:
URL: https://github.com/apache/kafka/pull/9520#discussion_r553437994
##########
File path: core/src/test/scala/unit/kafka/utils/QuotaUtilsTest.scala
##########
@@ -17,24 +17,21 @@
package kafka.utils
-import java.util.concurrent.TimeUnit
-
import org.apache.kafka.common.MetricName
-import org.apache.kafka.common.metrics.{KafkaMetric, MetricConfig, Quota,
QuotaViolationException}
import org.apache.kafka.common.metrics.stats.{Rate, Value}
-
-import scala.jdk.CollectionConverters._
+import org.apache.kafka.common.metrics.{KafkaMetric, MetricConfig, Quota,
QuotaViolationException}
import org.junit.Assert._
import org.junit.Test
-import org.scalatest.Assertions.assertThrows
+
+import java.util.concurrent.TimeUnit
class QuotaUtilsTest {
private val time = new MockTime
private val numSamples = 10
private val sampleWindowSec = 1
private val maxThrottleTimeMs = 500
- private val metricName = new MetricName("test-metric", "groupA", "testA",
Map.empty.asJava)
+ private val metricName = new MetricName("test-metric", "groupA", "testA",
java.util.Collections.emptyMap())
Review comment:
I would ignore IntelliJ issues if it compiles without warnings. I think
there are a few more changes like this in the middle of thousands of lines of
diff. Something to avoid in the future. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
