ijuma commented on a change in pull request #9520:
URL: https://github.com/apache/kafka/pull/9520#discussion_r552705598
##########
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##########
@@ -504,20 +510,21 @@ public void writePastLimit() {
}
}
- @Test(expected = IllegalArgumentException.class)
+ @Test
public void testAppendAtInvalidOffset() {
ByteBuffer buffer = ByteBuffer.allocate(1024);
buffer.position(bufferOffset);
long logAppendTime = System.currentTimeMillis();
- MemoryRecordsBuilder builder = new MemoryRecordsBuilder(buffer,
RecordBatch.MAGIC_VALUE_V1, compressionType,
+ MemoryRecordsBuilder builder = new MemoryRecordsBuilder(buffer,
RecordBatch.MAGIC_VALUE_V2, compressionType,
Review comment:
Unrelated to the changes in this PR then, just something you noticed?
Worth a line in the PR description to avoid confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
